我有一個網絡抓取應用程序，它可以簡單地從兩家大書店抓取書籍。這個想法是用戶在 URL 中放置類別類型，例如/romances，/biographies。控制器：_package bookstore.scraper.controller;imports...import java.util.List;import java.util.Map;@RestControllerpublic class BookController { private final MostPreciseBookService mostPreciseBookService; private final CategorizedBookService categorizedBookService; private final BestSellersService bestSellersService; @Autowired public BookController(MostPreciseBookService bookOperationsService, CategorizedBookService categorizedBookService, BestSellersService bestSellersService) { this.mostPreciseBookService = bookOperationsService; this.categorizedBookService = categorizedBookService; this.bestSellersService = bestSellersService; } ..... @GetMapping("/romances") public Map<Bookstore, List<Book>> get15RomanticBooks() { return categorizedBookService.get15BooksFromRomanceCategory(); } @GetMapping("/biographies") public Map<Bookstore, List<Book>> get15BiographiesBooks() { return categorizedBookService.get15BooksFromBiographiesCategory(); } @GetMapping("/guides") public Map<Bookstore, List<Book>> get15GuidesBooks() { return categorizedBookService.get15BooksFromGuidesCategory(); } @GetMapping("/fantasy") public Map<Bookstore, List<Book>> get15FantasyBooks() { return categorizedBookService.get15BooksFromFantasyCategory(); } @GetMapping("/crime") public Map<Bookstore, List<Book>> get15CrimeBooks() { return categorizedBookService.get15BooksFromCrimeCategory(); }}
1 回答
慕尼黑5688855
TA貢獻1848條經驗 獲得超2個贊
問題到底。在服務中使用那么多@Value 注釋是好方法嗎？/（使用 yml 文件存儲 URL）。
這不是因為您注入了太細粒度的屬性。這些應該被封裝到一個特定的對象中：更具可讀性、可維護性和可測試性。
Spring 提供@ConfigurationProperties這樣做。
它必須注釋包含屬性的類。
你可以這樣做：
@Component
@ConfigurationProperties("external.library.url")
public class BookStoreUrlProperties {
private Empik empik = new Empik();
private Merlin merlin = new Merlin();
// getters/setters
public BookStoreUrlProperties() {
}
public static class Empik {
private String romances;
private String biographies;
private String crime;
private String guides;
private String fantasy;
// getters/setters
}
public static class Merlin {
private String romances;
private String biographies;
private String crime;
private String guides;
private String fantasy;
// getters/setters
}
}
然后像任何其他 bean 一樣注入這個 bean：
@Autowired
BookStoreUrlProperties bookStoreUrlProperties;
并使用 getter 檢索 url，例如：
String RomanceUrl = bookStoreUrlProperties.getMerlin().getRomances();
我建議的另一種選擇是將屬性（merlin 和 empik）拆分為兩個屬性類。
關于服務類中的重復，您可以通過提取參數重構輕松地將它們分解出來，因為唯一的區別是 URL 值。
例如 ：
public Map<Bookstore, List<Book>> get15BooksFromGuidesCategory() {
return get15BooksFrom(guidesCategoryEmpikURL, guidesCategoryMerlinURL)
}
public Map<Bookstore, List<Book>> get15BooksFromBiographiesCategory() {
return get15BooksFrom(biographiesCategoryEmpikURL, biographiesCategoryMerlinURL)
}
public Map<Bookstore, List<Book>> get15BooksFrom(String bookStoreEmpikURL, String bookStoreMerlinURL) {
bookstoreWith15CategorizedBooks.put(Bookstore.EMPIK, empikBookService
.get15BooksFromCategory(connect(bookStoreEmpikURL)));
bookstoreWith15CategorizedBooks.put(Bookstore.MERLIN, merlinFetchingBookService
.get15BooksFromCategory(connect(bookStoreMerlinURL)));
return bookstoreWith15CategorizedBooks;
}
添加回答
舉報
0/150
提交
取消