@OverridepublicOptiongetTrafficChartOption(Stringtype,ReportTypereportType,IntegerdeviceId,Integerdirection){Integerdevice=deviceId+1010000;Listdata=chartDao.getTrafficChartData(reportType,device,direction);Stringtitle=Titlehelper.getChartTitle(reportType);Stringsubtitle=Titlehelper.gettrafficSubText(reportType.getReportTime(),deviceId,direction);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;}@OverridepublicOptiongetAmmeterChartOption(Stringtype,ReportTypereportType,IntegerdeviceId){Listdata=chartDao.getAmmeterDataChartData(reportType,deviceId);Stringtitle=Titlehelper.getChartTitle(reportType);Stringsubtitle=Titlehelper.gettrafficSubText(reportType.getReportTime(),deviceId,1);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;}代碼結構非常相似,只是dao層取數據不一樣,另外這個switch有沒有改進空間,我知道使用eumn來枚舉,沒寫以減少無關代碼
代碼重復求改進方法
郎朗坤
2019-05-25 15:28:02